Just learnt that the Chromium repo specified in "should be landed in the Chromium repo" at https://chromium.googlesource.com/chromium/src/build is actually "chromium/src" repo https://chromium.googlesource.com/chromium/src.git and not https://chromium.googlesource.com/chromium that I had cloned. So all good now, please ignore my previous message.
On Thursday, September 30, 2021 at 9:34:55 AM UTC-4 Gaby Baghdadi wrote: > > Thanks Jakob, I've submitted my first CL: > https://chromium-review.googlesource.com/c/v8/v8/+/3194879 > > That one depends on updates to the 'build' repository > https://chromium.googlesource.com/chromium/src/build, however, according > to https://chromium.googlesource.com/chromium/src/build: > > *Changes to //build should be landed in the Chromium repo. They will then > be replicated to the stand-alone build * > *repo by the gsubtreed tool. Note: You can find all directories already > available through gsubtreed in the list of all * > *chromium repos.* > > Since the following files under build/ obtained from 'fetch v8' aren't in > the 'build' dir from cloning https://chromium.googlesource.com/chromium, > where would I upload them from/to? > > config/BUILDCONFIG.gn > config/clang/clang.gni > config/compiler/BUILD.gn > config/compiler/compiler.gni > config/posix/BUILD.gn > toolchain/concurrent_links.gni > config/compiler/BUILD.gn > New: > config/zos/BUILD.gn > toolchain/zos/BUILD.gn > toolchain/zos_toolchain.gni > > For the following that are directly under '//build', do I upload them to > https://chromium.googlesource.com/chromium per the above instruction? > build_config.h > dotfile_settings.gni > On Friday, September 24, 2021 at 5:48:38 PM UTC-4 Jakob Kummerow wrote: > >> I'd group the changes by "topic", or kind of change. (It's a bit hard to >> say in the abstract, without having seen the changes.) >> >> E.g. I guess you'll add a new src/base/platform/, that could be its own >> CL. More generally: >> - any reasonably self-contained thing/concept that you're adding can be >> its own CL. >> - if you're making the same type of mechanical change (renaming, adding >> #includes, ...) across the codebase, one such change (or a group of tightly >> coupled / very similar changes) can be its own CL. >> - if those criteria aren't enough to get to manageable CL sizes, split by >> paths (e.g. src/base/, src/*, test/cctests/, test/unittests/, ...). For the >> definition of "manageable", ask yourself what you'd like to review. As a >> rough guideline, if it's more than 500 lines or more than 20 files at once, >> I'd ask whether that's really the smallest unit that makes sense. >> (Sometimes it is!) >> >> >> On Fri, Sep 24, 2021 at 6:51 PM Gaby Baghdadi <gabyba...@gmail.com> >> wrote: >> >>> Hi. I'd like to upload changes to V8, build and icu repositories to >>> enable V8 to build on z/OS (which runs on the s390 platforms that are >>> already supported with Linux). >>> >>> The 'git diff' for the V8 changes is about 4000 lines, and affects some >>> 150 src/, include/, test/, etc. files. Please advise on how to break up the >>> upload, or if all changes should be uploaded in a single patch. >>> >>> Thanks. >>> >>> -- >>> -- >>> v8-dev mailing list >>> v8-...@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+un...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/cd743160-e23f-4148-8269-5f90d639854en%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/v8-dev/cd743160-e23f-4148-8269-5f90d639854en%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/1bef89f4-d8d7-4e37-8e10-0411ab59e9f4n%40googlegroups.com.
