Hi all, In `tools/gen-keywords-gen-h.py`[1]
if (IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH)) should be if (base::IsInRange(len, MIN_WORD_LENGTH, MAX_WORD_LENGTH)) This commit[2] introduced base namespace but didn't change the python script accordingly. I read from doc[3] that merge request only accept severe bug fix, so I'll drop this tiny fix in the mailing list. Regards, Jiading [1] https://source.chromium.org/chromium/chromium/src/+/main:v8/tools/gen-keywords-gen-h.py;l=86;drc=fcd0cf445426fb2a2d0079c50e3d16026a13295e [2] https://chromium-review.googlesource.com/c/v8/v8/+/1916604 [3] https://v8.dev/docs/merge-patch -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/b527c561-b176-445a-af7d-e12aa0505ce7n%40googlegroups.com.