>From git blame, it looks like this change was simply meant as a cleanup in https://chromium-review.googlesource.com/c/v8/v8/+/3780538, where the previous default implementation simply returned nullptr. So at first glance it looks like having your platform return nullptr ought to work. Adding the CL author & reviewer to this thread for confirmation.
On Sat, Oct 15, 2022 at 6:54 AM ClearScript Developers < clearscript...@gmail.com> wrote: > We got no response to this on the v8-users group, so we thought we'd try > here. > > "Our embedder has a custom v8::Platform implementation. In V8 10.6+, > v8::Platform::GetPageAllocator is abstract, and no information is provided > about how to implement it. > > We're currently delegating GetPageAllocator to an instance of the default > platform (created via v8::platform::NewDefaultPlatform). That seems to work > but feels hacky. Before this we never had any reason to instantiate the > default platform. > > Is this an oversight? Most v8::Platform methods are relatively mundane – > task scheduling, raw memory allocation, etc. – whereas v8::PageAllocator is > quite esoteric, and many embedders would probably not know how to implement > it." > > Since that original post, we've run into a problem with the default > platform (a deadlock at process shutdown on Windows 7 if the default > platform is owned by a static object), so we're now patching V8 to expose > v8::base::PageAllocator instead. > > Any comments or recommendations from the V8 team? > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/b5bf5bce-37ca-4cbf-bc1c-81d0f259e74en%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/b5bf5bce-37ca-4cbf-bc1c-81d0f259e74en%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAEvLGcJYO985o5KsibA5YbkPqO-%3DyLMiCTwnKYphetWFLAEmCA%40mail.gmail.com.
