This looks like a C++20 build using a non C++20 standard lib. Adding Helmut who landed the change (https://crrev.com/c/5079350) -- if it's causing issues it's an easy revert.
On Wed, Dec 13, 2023 at 9:31 AM Meir Shpilraien <[email protected]> wrote: > Hey > > Yesterday we started to see failure on our mac build on the main branch > (which we do not see on official version). The failure: > > FAILED: obj/torque_generated_definitions/api-callbacks-tq.o > 582 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:583>../../third_party/llvm-build/Release+Asserts/bin/clang++ > -MMD -MF obj/torque_generated_definitions/api-callbacks-tq.o.d > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 > -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE > -DCR_XCODE_VERSION=1420 > -DCR_CLANG_REVISION=\"llvmorg-18-init-12938-geb1d5065-1\" -DNDEBUG > -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 > -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE > -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES > -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP > -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH > -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE -DV8_ENABLE_SPARKPLUG > -DV8_ENABLE_MAGLEV -DV8_ENABLE_TURBOFAN -DV8_ENABLE_SYSTEM_INSTRUMENTATION > -DV8_ENABLE_WEBASSEMBLY -DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA > -DV8_ALLOCATION_FOLDING -DV8_ALLOCATION_SITE_TRACKING > -DV8_ADVANCED_BIGINT_ALGORITHMS -DV8_STATIC_ROOTS -DV8_USE_ZLIB > -DV8_USE_LIBM_TRIG_FUNCTIONS -DV8_ENABLE_WASM_SIMD256_REVEC > -DV8_ENABLE_MAGLEV_GRAPH_PRINTER -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH > -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT -DV8_COMPRESS_POINTERS > -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE -DV8_31BIT_SMIS_ON_64BIT_ARCH > -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS > -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP > -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION > -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS > -DV8_TARGET_OS_MACOS -DV8_RUNTIME_CALL_STATS -DABSL_ALLOCATOR_NOTHROW=1 > -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 > -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 > -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. > -Igen -I../../include -I../../third_party/abseil-cpp > -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n > -Igen/include -Wall -Wextra -Wimplicit-fallthrough -Wextra-semi > -Wunreachable-code-aggressive -Wthread-safety -Wunguarded-availability > -Wno-missing-field-initializers -Wno-unused-parameter -Wno-psabi > -Wloop-analysis -Wno-unneeded-internal-declaration > -Wenum-compare-conditional -Wno-ignored-pragma-optimize > -Wno-deprecated-builtins -Wno-bitfield-constant-conversion > -Wno-deprecated-this-capture -Wno-invalid-offsetof -Wno-vla-extension > -Wno-thread-safety-reference-return -Wshadow > -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing > -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics > -fmerge-all-constants > -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm > -instcombine-lower-dbg-declare=0 -mllvm > -split-threshold-for-reg-with-hint=0 -ffp-contract=off > --target=x86_64-apple-macos -Wno-builtin-macro-redefined -D__DATE__= > -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. > -no-canonical-prefixes -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang > -debug-info-kind=limited -isysroot ../../../../../../../../../Applications/ > Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk > -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion > -Wtautological-overlap-compare -Wmissing-field-initializers > -Wunreachable-code -Wno-shadow -Wctad-maybe-unsupported -Wshorten-64-to-32 > -Wno-invalid-offsetof -O3 -fno-math-errno -fvisibility=default > -Wexit-time-destructors -std=c++20 -Wno-trigraphs -fno-exceptions -fno-rtti > -c gen/torque-generated/src/objects/api-callbacks-tq.cc -o > obj/torque_generated_definitions/api-callbacks-tq.o > 583 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:584>In > file included from gen/torque-generated/src/objects/api-callbacks-tq.cc:1: > 584 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:585>In > file included from ../../src/objects/api-callbacks-inl.h:10: > 585 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:586>In > file included from ../../src/heap/heap-write-barrier-inl.h:16: > 586 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:587>In > file included from ../../src/objects/compressed-slots-inl.h:10: > 587 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:588>../../src/common/ptr-compr-inl.h:39:36: > error: no member named 'assume_aligned' in namespace 'std' > 588 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:589> > 39 | base = reinterpret_cast<Address>(V8_ASSUME_ALIGNED( > 589 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:590> > | ^~~~~~~~~~~~~~~~~~ > 590 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:591> > 40 | reinterpret_cast<void*>(base), kPtrComprCageBaseAlignment)); > 591 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:592> > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 592 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:593>../../include/v8config.h:487:8: > note: expanded from macro 'V8_ASSUME_ALIGNED' > 593 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:594> > 487 | std::assume_aligned<(alignment)>(ptr) > 594 > <https://github.com/RedisGears/v8-build/actions/runs/7190929695/job/19584854213#step:7:595> > | ~~~~~^ > > I was wondering if something got broken recently? Or maybe we are doing > something wrong? > > Thanks, > Meir > > > *Disclaimer* > > The information contained in this communication from the sender is > confidential. It is intended solely for use by the recipient and others > authorized to receive it. If you are not the recipient, you are hereby > notified that any disclosure, copying, distribution or taking action in > relation of the contents of this information is strictly prohibited and may > be unlawful. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/44dac5db-03cf-4dbd-b0a3-e1a0c9067771n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/44dac5db-03cf-4dbd-b0a3-e1a0c9067771n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGRskv8-SruhaQT6qzxQWHq5rs%2BMkkT70oqWuFGsGO8ayzZMew%40mail.gmail.com.
