http://codereview.chromium.org/660375/diff/7/1002 File src/runtime.cc (right):
http://codereview.chromium.org/660375/diff/7/1002#newcode4947 src/runtime.cc:4947: ASSERT(args[0]->IsSmi()); On 2010/03/02 14:07:53, antonm wrote:
I think we should either have ASSERTs and use Smi::cast or
CONVERT_SMI_CHECKED. I've removed the ASSERTs. http://codereview.chromium.org/660375/diff/7/1002#newcode4971 src/runtime.cc:4971: On 2010/03/02 14:01:19, Vitaly wrote:
Just an idea: Does it make sense to assert 'month' is in the valid
range here? Done. http://codereview.chromium.org/660375 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
