Thanks, I can confirm the compilation issue is solved. On Thursday 4 April 2024 at 17:06:59 UTC+3 Clemens Backes wrote:
> FYI, this was fixed via https://crrev.com/c/5423131. > > On Thu, Apr 4, 2024 at 10:45 AM Clemens Backes <clem...@chromium.org> > wrote: > >> This is pretty old code, but indeed the include is missing there. I don't >> see a recent change that would explain the sudden compile failure, but >> the right fix is anyway to just add the missing include. I'll upload a CL. >> >> On Thu, Apr 4, 2024 at 10:30 AM 'Meir Shpilraien' via v8-dev < >> v8-...@googlegroups.com> wrote: >> >>> Hey >>> >>> Yesterday we started to see failure on our linux build on the main >>> branch (which we do not see on official version). The failure: >>> >>> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF >>> obj/v8_base_without_compiler/wasm-import-wrapper-cache.o.d >>> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 >>> -D_LIBCPP_HARDENING_MODE=_LIBCPP_HARDENING_MODE_NONE >>> -DCR_XCODE_VERSION=1420 >>> -DCR_CLANG_REVISION=\"llvmorg-19-init-6501-g5b544b51-1\" -DNDEBUG >>> -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 >>> -DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=64 -DENABLE_GDB_JIT_INTERFACE >>> -DV8_INTL_SUPPORT -DV8_ATOMIC_OBJECT_FIELD_WRITES >>> -DV8_ENABLE_LAZY_SOURCE_POSITIONS -DV8_SHARED_RO_HEAP >>> -DV8_WIN64_UNWINDING_INFO -DV8_ENABLE_REGEXP_INTERPRETER_THREADED_DISPATCH >>> -DV8_ENABLE_FUZZTEST -DV8_SHORT_BUILTIN_CALLS -DV8_EXTERNAL_CODE_SPACE >>> -DV8_ENABLE_SPARKPLUG -DV8_ENABLE_MAGLEV -DV8_ENABLE_TURBOFAN >>> -DV8_ENABLE_SYSTEM_INSTRUMENTATION -DV8_ENABLE_WEBASSEMBLY >>> -DV8_ENABLE_CONTINUATION_PRESERVED_EMBEDDER_DATA -DV8_ALLOCATION_FOLDING >>> -DV8_ALLOCATION_SITE_TRACKING -DV8_ADVANCED_BIGINT_ALGORITHMS >>> -DV8_STATIC_ROOTS -DV8_USE_ZLIB -DV8_USE_LIBM_TRIG_FUNCTIONS >>> -DV8_ENABLE_WASM_SIMD256_REVEC -DV8_ENABLE_MAGLEV_GRAPH_PRINTER >>> -DV8_ENABLE_BUILTIN_JUMP_TABLE_SWITCH -DV8_ENABLE_EXTENSIBLE_RO_SNAPSHOT >>> -DV8_COMPRESS_POINTERS -DV8_COMPRESS_POINTERS_IN_SHARED_CAGE >>> -DV8_31BIT_SMIS_ON_64BIT_ARCH -DV8_ENABLE_SANDBOX -DV8_DEPRECATION_WARNINGS >>> -DV8_IMMINENT_DEPRECATION_WARNINGS -DCPPGC_CAGED_HEAP >>> -DCPPGC_YOUNG_GENERATION -DCPPGC_POINTER_COMPRESSION >>> -DCPPGC_SLIM_WRITE_BARRIER -DV8_TARGET_ARCH_X64 -DV8_HAVE_TARGET_OS >>> -DV8_TARGET_OS_MACOS -DV8_RUNTIME_CALL_STATS -DABSL_ALLOCATOR_NOTHROW=1 >>> -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1 >>> -DU_ENABLE_TRACING=1 -DU_ENABLE_RESOURCE_TRACING=0 >>> -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../.. >>> -Igen -I../../include -I../../third_party/abseil-cpp -Igen/include >>> -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n >>> -I../../third_party/fp16/src/include -I../../third_party/zlib -Wall -Wextra >>> -Wimplicit-fallthrough -Wextra-semi -Wunreachable-code-aggressive >>> -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers >>> -Wno-unused-parameter -Wno-psabi -Wloop-analysis >>> -Wno-unneeded-internal-declaration -Wno-cast-function-type >>> -Wno-ignored-pragma-optimize -Wno-deprecated-builtins >>> -Wno-bitfield-constant-conversion -Wno-deprecated-this-capture >>> -Wno-invalid-offsetof -Wno-vla-extension >>> -Wno-thread-safety-reference-return -Wshadow >>> -fno-delete-null-pointer-checks -fno-ident -fno-strict-aliasing >>> -fstack-protector -femit-dwarf-unwind=no-compact-unwind -fcolor-diagnostics >>> -fmerge-all-constants >>> -fcrash-diagnostics-dir=../../tools/clang/crashreports -mllvm >>> -instcombine-lower-dbg-declare=0 -mllvm >>> -split-threshold-for-reg-with-hint=0 -ffp-contract=off >>> --target=x86_64-apple-macos -Wno-builtin-macro-redefined -D__DATE__= >>> -D__TIME__= -D__TIMESTAMP__= -ffile-compilation-dir=. >>> -no-canonical-prefixes -fno-omit-frame-pointer -g2 -gdwarf-aranges -Xclang >>> -debug-info-kind=limited -isysroot ../../../../../../../../../Applications/ >>> Xcode_14.2.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.1.sdk >>> >>> -mmacos-version-min=10.15 -Wheader-hygiene -Wstring-conversion >>> -Wtautological-overlap-compare -Wunreachable-code -Wno-shadow >>> -Wctad-maybe-unsupported -Wno-invalid-offsetof -Wshorten-64-to-32 >>> -Wmissing-field-initializers -O3 -fno-math-errno -fvisibility=default >>> -Wexit-time-destructors -Wno-gcc-compat -Wno-unreachable-code-break >>> -Wenum-compare-conditional -Wno-c++11-narrowing-const-reference -std=c++20 >>> -Wno-trigraphs -fno-exceptions -fno-rtti -c >>> ../../src/wasm/wasm-import-wrapper-cache.cc -o >>> obj/v8_base_without_compiler/wasm-import-wrapper-cache.o >>> 2008 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2009>In >>> >>> file included from ../../src/wasm/wasm-import-wrapper-cache.cc:5: >>> 2009 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2010>../../src/wasm/wasm-import-wrapper-cache.h:92:8: >>> >>> error: no template named 'unordered_map' in namespace 'std' >>> 2010 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2011> >>> >>> 92 | std::unordered_map<CacheKey, WasmCode*, CacheKeyHash> entry_map_; >>> 2011 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2012> >>> >>> | ~~~~~^ >>> 2012 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2013>../../src/wasm/wasm-import-wrapper-cache.h:92:57: >>> >>> warning: private field 'entry_map_' is not used [-Wunused-private-field] >>> 2013 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2014> >>> >>> 92 | std::unordered_map<CacheKey, WasmCode*, CacheKeyHash> entry_map_; >>> 2014 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2015> >>> >>> | ^ >>> 2015 >>> <https://github.com/RedisGears/v8-build/actions/runs/8549498430/job/23424926439#step:7:2016>1 >>> >>> warning and 1 error generated. >>> >>> We do not see this failure on the Mac build. >>> I was wondering if something changed recently that could have cause it? >>> >>> >>> *Disclaimer* >>> >>> The information contained in this communication from the sender is >>> confidential. It is intended solely for use by the recipient and others >>> authorized to receive it. If you are not the recipient, you are hereby >>> notified that any disclosure, copying, distribution or taking action in >>> relation of the contents of this information is strictly prohibited and may >>> be unlawful. >>> >>> -- >>> -- >>> v8-dev mailing list >>> v8-...@googlegroups.com >>> http://groups.google.com/group/v8-dev >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "v8-dev" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to v8-dev+un...@googlegroups.com. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/v8-dev/02724841-2ae7-40af-b7b5-9e6ba6258d99n%40googlegroups.com >>> >>> <https://groups.google.com/d/msgid/v8-dev/02724841-2ae7-40af-b7b5-9e6ba6258d99n%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> >> >> -- >> >> Clemens Backes >> >> Software Engineer >> >> clem...@google.com >> >> Google Germany GmbH >> >> Erika-Mann-Straße 33 >> >> 80636 München >> >> Geschäftsführer: Paul Manicle, Liana Sebastian >> >> Registergericht und -nummer: Hamburg, HRB 86891 >> >> Sitz der Gesellschaft: Hamburg >> >> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten >> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, >> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, >> dass die E-Mail an die falsche Person gesendet wurde. >> >> >> This e-mail is confidential. If you received this communication by >> mistake, please don't forward it to anyone else, please erase all copies >> and attachments, and please let me know that it has gone to the wrong >> person. >> >> >> > > -- > > Clemens Backes > > Software Engineer > > clem...@google.com > > Google Germany GmbH > > Erika-Mann-Straße 33 > > 80636 München > > Geschäftsführer: Paul Manicle, Liana Sebastian > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, > dass die E-Mail an die falsche Person gesendet wurde. > > > This e-mail is confidential. If you received this communication by > mistake, please don't forward it to anyone else, please erase all copies > and attachments, and please let me know that it has gone to the wrong > person. > > > Disclaimer The information contained in this communication from the sender is confidential. It is intended solely for use by the recipient and others authorized to receive it. If you are not the recipient, you are hereby notified that any disclosure, copying, distribution or taking action in relation of the contents of this information is strictly prohibited and may be unlawful. This email has been scanned for viruses and malware, and may have been automatically archived by Mimecast Ltd, an innovator in Software as a Service (SaaS) for business. Providing a safer and more useful place for your human generated data. Specializing in; Security, archiving and compliance. To find out more visit the Mimecast website. -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/f6020936-ed78-450e-ad30-5b44bbed9eaan%40googlegroups.com.
