The "build" repository isn't part of V8, it's an external dependency. I don't know how to make contributions to it. Perhaps from a full Chromium checkout? At any rate, it's out of scope for this mailing list.
On Thu, Jun 13, 2024 at 10:40 AM jojo <rjie...@gmail.com> wrote: > Hi, > I am a newbie here as contributor, I follow steps of the guide > https://v8.dev/docs/contribute, > then I can request my code review for v8 repository, but I met > persimmon deny if i request code review in "build" repository, all > configures same as the v8 like the guide's said. > > Anyone can give me some hints to fix this ? the error log as following, > thanks. > > build % git cl upload > > Found change with 1 commit... > Running Python 3 presubmit upload checks ... > ** Presubmit Warnings: 1 ** > $home/repo/v8-fetch/v8/build/PRESUBMIT_test.py > vpython3 $home/repo/v8-fetch/v8/build/PRESUBMIT_test.py (0.27s) failed > Traceback (most recent call last): > File "$home/repo/v8-fetch/v8/build/PRESUBMIT_test.py", line 14, in > <module> > from PRESUBMIT_test_mocks import MockAffectedFile > ModuleNotFoundError: No module named 'PRESUBMIT_test_mocks' > > > There were Python 3 presubmit warnings. Are you sure you wish to continue? > (y/N): y > Waiting for editor... > > saving CL description to $home/repo/depot_tools/.git_cl_description_backup > > remote: PERMISSION_DENIED: The caller does not have permission > remote: [type.googleapis.com/google.rpc.RequestInfo] > remote: request_id: "58e74b7859534f70b33ca15bc5fa18d0" > remote: > remote: [type.googleapis.com/google.rpc.RequestInfo] > remote: request_id: "2718038136e54d3385785dceeaaf425e" > fatal: unable to access ' > https://chromium.googlesource.com/chromium/src/build.git/': The requested > URL returned error: 403 > Traceback (most recent call last): > File "$home/repo/depot_tools/git_cl.py", line 2942, in > _RunGitPushWithTraces > push_stdout = gclient_utils.CheckCallAndFilter( > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "$home/repo/depot_tools/gclient_utils.py", line 714, in > CheckCallAndFilter > raise subprocess2.CalledProcessError(rv, args, kwargs.get('cwd', None), > subprocess2.CalledProcessError: Command 'git push > https://chromium.googlesource.com/chromium/src/build.git > 4d7e6e862bc9000213821a4cec6eb9009e641def:refs/for/refs/heads/main%m=Initial_upload,hashtag=riscv' > returned non-zero exit status 128 > remote: PERMISSION_DENIED: The caller does not have permission > remote: [type.googleapis.com/google.rpc.RequestInfo] > remote: request_id: "58e74b7859534f70b33ca15bc5fa18d0" > remote: > remote: [type.googleapis.com/google.rpc.RequestInfo] > remote: request_id: "2718038136e54d3385785dceeaaf425e" > fatal: unable to access ' > https://chromium.googlesource.com/chromium/src/build.git/': The requested > URL returned error: 403 > > > During handling of the above exception, another exception occurred: > > Traceback (most recent call last): > File "$home/repo/depot_tools/metrics.py", line 289, in > print_notice_and_exit > yield > File "$home/repo/depot_tools/git_cl.py", line 6718, in <module> > sys.exit(main(sys.argv[1:])) > ^^^^^^^^^^^^^^^^^^ > File "$home/repo/depot_tools/git_cl.py", line 6701, in main > return dispatcher.execute(OptionParser(), argv) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "$home/repo/depot_tools/subcommand.py", line 254, in execute > return command(parser, args[1:]) > ^^^^^^^^^^^^^^^^^^^^^^^^^ > File "$home/repo/depot_tools/git_cl.py", line 5074, in CMDupload > UploadAllSquashed(options, orig_args) > File "$home/repo/depot_tools/git_cl.py", line 5211, in UploadAllSquashed > push_stdout = cl._RunGitPushWithTraces(refspec, refspec_opts, > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > File "$home/repo/depot_tools/git_cl.py", line 2975, in > _RunGitPushWithTraces > raise GitPushError( > GitPushError: Failed to create a change. Please examine output above for > the reason of the failure. > For emergencies, Googlers can escalate to go/gob-support > <https://goto.google.com/gob-support> or go/notify#gob > <https://goto.google.com/notify#gob> > Hint: run command below to diagnose common Git/Gerrit credential problems: > git cl creds-check > > If git-cl is not working correctly, file a bug under the Infra>SDK > component including the files below. > Review the files before upload, since they might contain sensitive > information. > Set the Restrict-View-Google label so that they are not publicly > accessible. > > The traces of this git-cl execution have been recorded at: > $home/repo/depot_tools/traces/20240613T094057.204543-traces.zip > Copies of your gitcookies file and git config have been recorded at: > $home/repo/depot_tools/traces/20240613T094057.204543-git-info.zip > > -- > Thanks, > > - Jojo > > -- > -- > v8-dev mailing list > v8-dev@googlegroups.com > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to v8-dev+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/CAHXxEWstXO%3D8vFUyufrLDfm6JQAY9U8QZwWgB%3D8bcLjGQ6jz_A%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-dev/CAHXxEWstXO%3D8vFUyufrLDfm6JQAY9U8QZwWgB%3D8bcLjGQ6jz_A%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to v8-dev+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAKSzg3RDRwka4wgJLAz_avKw%3DJ6tn%2BNZeJsicXX9rWKJ241%2Bkg%40mail.gmail.com.