This is a DCHECK that is verifying that we are only including allocatable registers in the temporary register scope, since we only want to use temporaries that maglev's register allocator chose for us, and this only uses allocatable registers. The per-architecture scratch registers are not allowed to be used here, because various macro assembler functions assume that they have free reign over scratch registers.
On Fri, Sep 27, 2024 at 1:38 PM Yahan Lu <[email protected]> wrote: > ``` > void Include(const RegList list) { > DCHECK((list - kAllocatableGeneralRegisters).is_empty()); > available_ = available_ | list; > } > ``` > > In my understand that temp reg should are taken out of the allocatable > register set. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/v8-dev/ae36c383-6405-4b13-bfc3-333f03d3dbb1n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/ae36c383-6405-4b13-bfc3-333f03d3dbb1n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/v8-dev/CAGRskv_fYSHtscs_djvXVq-BShtp%2BEh_vwNbmjk29DxTqFahZw%40mail.gmail.com.
