Do you have to have entered the isolate to call the destructor of
v8::Global?

Here we have
https://chromium.googlesource.com/v8/v8.git/+/da4e529cfddb93e7166666c447a94d173e1e682f/test/cctest/test-serialize.cc#548
a Global that is above the isolate scope, so it gets destroyed after the
isolate scope was destroyed, and the isolate was exited.  Is this
OK/harmless/bad taste?

We could swap those and add a DCHECK in the Global destructor to ensure
there is a current isolate.

-- 
Erik

-- 
-- 
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- 
You received this message because you are subscribed to the Google Groups 
"v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/v8-dev/CAHZxHpiTNcwMxoV5BKX64TB4gwJww6HvKf3d4ZgWY1iPV8vH6w%40mail.gmail.com.

Reply via email to