I wonder if it is possible to get access to that design doc? Or make it public?
Best, David On Tue, Feb 18, 2025, 3:39 AM Clemens Backes <[email protected]> wrote: > We will have to remove most (or all) calls to GetHeapFromWritableObject > <https://source.chromium.org/chromium/chromium/src/+/main:v8/src/execution/isolate-utils-inl.h;l=16;drc=ee7f7a4f27cf1abee8b8e641d5da28c4f11cd866> > and its callers (in particular all the Object::GetHeap() and > Object::GetIsolate() methods > <https://source.chromium.org/chromium/chromium/src/+/main:v8/src/objects/object-macros.h;l=88;drc=798b98d70313e6a55bcf9cc85bc7ca7d42ca6d23>) > to ensure sandbox safety. The alternative is reading the current isolate > from TLS via Isolate::Current() > <https://source.chromium.org/chromium/chromium/src/+/main:v8/src/execution/isolate.cc;l=522;drc=798b98d70313e6a55bcf9cc85bc7ca7d42ca6d23> > . > > See the design doc > <https://docs.google.com/document/d/1kSOQGwKjM_bbbMD0FHNL2ZiP9S5NRUfAva1wRnJqtNg/edit?usp=sharing&resourcekey=0-yxgCnOE-xEU0j3Dx96OZBA> > for details. > > -- > > Clemens Backes > > Software Engineer > > [email protected] > > Google Germany GmbH > > Erika-Mann-Straße 33 > <https://www.google.com/maps/search/Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen?entry=gmail&source=g> > > 80636 München > <https://www.google.com/maps/search/Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen?entry=gmail&source=g> > > Geschäftsführer: Paul Manicle, Liana Sebastian > > Registergericht und -nummer: Hamburg, HRB 86891 > > Sitz der Gesellschaft: Hamburg > > Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten > haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, > löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, > dass die E-Mail an die falsche Person gesendet wurde. > > > This e-mail is confidential. If you received this communication by > mistake, please don't forward it to anyone else, please erase all copies > and attachments, and please let me know that it has gone to the wrong > person. > > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/v8-dev/CAGO%3DqhD%3DMTQrKgmDbWM5KCmOuXxOv-cOmTs4EFfuMY1f51pLuA%40mail.gmail.com > <https://groups.google.com/d/msgid/v8-dev/CAGO%3DqhD%3DMTQrKgmDbWM5KCmOuXxOv-cOmTs4EFfuMY1f51pLuA%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAPdMgufQSPxa7QW4wJ%3D8-0LdGG7gRb2KsrURi6ErZJ15kyEn9w%40mail.gmail.com.
