On Thu, Apr 10, 2025 at 6:55 PM Ben Noordhuis <[email protected]> wrote:
> > > HandleScope::DeleteExtensions depends on thread-local state, grep > around for HandleScopeData. Sooner or later you're going to call into > V8 right when it's updating said state. Node doesn't enter/exit > isolates often, but still. > Will look into it, thanks for the pointer! > > That Environment::RunTimers shows up in the stack trace is not > unexpected; it changes the active context and that's another point > where you're racing the thread from the signal handler. > Would that context not be scoped around the "cb->Call(env->context(), process, 1, &arg);" invocations inside the loop, though? I'd expect that as soon as Call() returns the context is unset, so I wouldn't expect a problem there, and what definitely surprised me was Isolate being in a context (or at least, claiming to be in one) during execution within the HandleScope destructor. To make matters even more intriguing, this only seems to trigger on worker threads, and never on the main event loop thread. > Is this a new or existing problem? I remember someone from DD reaching > out to me about this or a very similar problem 1-2 years ago, asking > if I was interested in coming in as a consultant (I work on V8, node > and libuv) but I didn't have time back then. > I've been with Datadog for about 2 years now myself, and I don't think it came up since I've been here. The functionality I implemented recently for capturing the async IDs during sampling is new. Thanks! Attila. > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/v8-dev/CAHQurc-aw9wjd40aXhnLUyTkhJ_cVY%2BFb24kjmVu1n%2BaRZvT2w%40mail.gmail.com > . > -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CADatEgYVM2ZRWoBcSX2a8YYdqep9Xx-FtfX%2BWZC2FVBev5GXgQ%40mail.gmail.com.
