As noted on the CL <https://crrev.com/c/6678631>, I think renaming everything is the right fix.
On Mon, Jun 30, 2025 at 10:19 AM Ellison Chen < [email protected]> wrote: > Hello, > > I'm new to the community and wanted to just change the spelling of a > fallthrough error message, seen in this > <https://github.com/nodejs/node/issues/58805>issue in the Node.js repo > which suggests that the spelling should be corrected upstream, to v8. > > I'm looking into changing the spelling of the error messages, however, > without changing the respective variables from fallthru to fallthrough, it > would make it more difficult to find the respective errors and/or error > messages. > > I'm thinking it would be necessary that all instances of the term > "fallthru" should be changed to "fallthrough" in order to resolve this > issue. > > Please let me know any thoughts, thanks! > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/v8-dev/de8663d3-6749-4c95-86a7-26a31a5c89ebn%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/de8663d3-6749-4c95-86a7-26a31a5c89ebn%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Clemens Backes Software Engineer [email protected] Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CAGO%3DqhBfQCNco%3Dxrxr0BE2xuTiZUqsT2O%3DPDxavhzwyCWx54zQ%40mail.gmail.com.
