Configuring warnings as errors will always lead to "breaking changes" if the set of warnings between the library (v8) and the client mismatches. It seems that
// first line \ // second line produces a warning with -Wcomment. This warning is not included in either -Wextra nor -Wpedantic, so I'm not sure how V8 could make sure that no client breaks if they enable additional warnings while also running with warnings as errors. Furthermore, this does not produce a warning in clang only in gcc ( https://godbolt.org/z/9b71ab57f) which is not officially supported. So from a V8 perspective this header file is perfectly fine and I'd argue the issue is in the build configuration of the project including V8. (We could "fix" this as a one-off but that doesn't mean that this won't reappear or that other additional warnings couldn't lead to any other such issues.) On Mon, Sep 1, 2025 at 1:19 PM Jeroen Ooms <[email protected]> wrote: > Client applications building against v8 see a warning: > > ../include/v8-internal.h:436:1: warning: multi-line comment [-Wcomment] > > The bug is that this file contains an (otherwise beautiful!) ascii diagram > in it's comments, however two lines of this drawing end with a backslash, > which get interpreted as an escape. > > Because this is a header file that gets included by client applications, > it may actually break applications that build with -Werror. > > > > > > -- > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > --- > You received this message because you are subscribed to the Google Groups > "v8-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion visit > https://groups.google.com/d/msgid/v8-dev/0d3f6ed1-6ef2-45e5-ab05-aa77c0fbed67n%40googlegroups.com > <https://groups.google.com/d/msgid/v8-dev/0d3f6ed1-6ef2-45e5-ab05-aa77c0fbed67n%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- Matthias Liedtke Software Engineer [email protected] Google Germany GmbH Erika-Mann-Straße 33 80636 München Geschäftsführer: Paul Manicle, Liana Sebastian Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg Diese E-Mail ist vertraulich. Falls Sie diese fälschlicherweise erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail an die falsche Person gesendet wurde. This e-mail is confidential. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. -- -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion visit https://groups.google.com/d/msgid/v8-dev/CACx9iAOcp8sG%3DzVZrJwwu2XoKrN0Rcpgg_25HSHt0t5wRC69kQ%40mail.gmail.com.
