http://codereview.chromium.org/857003/diff/3001/4001 File src/ia32/ic-ia32.cc (right):
http://codereview.chromium.org/857003/diff/3001/4001#newcode245 src/ia32/ic-ia32.cc:245: const int kDetailsOffset = kElementsStartOffset + 2 * kPointerSize; On 2010/03/12 07:59:45, Søren Gjesse wrote:
ASSERT(NORMAL == 0)?
Done. http://codereview.chromium.org/857003/diff/3001/4001#newcode248 src/ia32/ic-ia32.cc:248: __ j(not_zero, miss); On 2010/03/12 07:59:45, Søren Gjesse wrote:
Shouldn't the DeletedField of the details be checked here as well?
We don't have to. When deleting an element, we clear the key as well so we will fail before getting here. http://codereview.chromium.org/857003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
