On Tue, Mar 16, 2010 at 16:58, Oleg Eterevsky <ol...@google.com> wrote: >>> > Drive-by comment: Is it worth doing some of the work in math.js like we >>> > do for floor? >>> You mean, check for SMI in math.js rather then in runtime.cc? What >>> difference does it make? We'll still have to call C++ function, so >>> there'll be an overhead of CEntryStub. >> No, you can check for a Smi without using a C++ function using %_IsSmi > Actually, I was thinking of the conversion itself, but now I see. I'll > try to do it and see if there's any difference.
I tried to move the range check and SMI conversion to math.js. It appeared to be slightly slower. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
