LGTM!
http://codereview.chromium.org/993002/diff/49001/50003 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/993002/diff/49001/50003#newcode4753 src/arm/codegen-arm.cc:4753: // We have -1, 0 or 1, which we treat specially. Could we clearify the comment to state that source contains a positive number (and therefore the removal of the compare to zero is correct). http://codereview.chromium.org/993002/diff/49001/50004 File src/arm/codegen-arm.h (right): http://codereview.chromium.org/993002/diff/49001/50004#newcode680 src/arm/codegen-arm.h:680: // Minor key encoding in 16 bits. This is not new code, but we do not seem to use these bit fields. Could you change this to follow the pattern used for the other stubs. Define BitFields here and create the MinorKey using bitwise or of the bitfield encodings? http://codereview.chromium.org/993002/diff/49001/50004#newcode687 src/arm/codegen-arm.h:687: return the_int_.code() + Please remove extra space. http://codereview.chromium.org/993002/diff/49001/50010 File src/arm/ic-arm.cc (right): http://codereview.chromium.org/993002/diff/49001/50010#newcode650 src/arm/ic-arm.cc:650: const int meaningfull_bits = kBitsPerInt - leading_zeroes - 1; meaningfull -> meaningful http://codereview.chromium.org/993002/diff/49001/50010#newcode697 src/arm/ic-arm.cc:697: // Check that the object is a JS object. Load map into r2 End comment with period. http://codereview.chromium.org/993002/diff/49001/50010#newcode719 src/arm/ic-arm.cc:719: Remove empty line? http://codereview.chromium.org/993002/diff/49001/50010#newcode797 src/arm/ic-arm.cc:797: __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET); Please use "__ TailCallStub(&stub);" http://codereview.chromium.org/993002 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
