Thanks!
http://codereview.chromium.org/1169002/diff/1/2 File test/cctest/test-log-stack-tracer.cc (right): http://codereview.chromium.org/1169002/diff/1/2#newcode215 test/cctest/test-log-stack-tracer.cc:215: ret_addr, On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done. http://codereview.chromium.org/1169002/diff/1/2#newcode294 test/cctest/test-log-stack-tracer.cc:294: CHECK(!CompileRun( On 2010/03/23 11:53:28, Kasper Lund wrote:
I would create a local handle for the result and do
CHECK(!result.IsEmpty())
separately.
Good point. Done. http://codereview.chromium.org/1169002/diff/1/2#newcode303 test/cctest/test-log-stack-tracer.cc:303: sample.stack[0]); On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done. http://codereview.chromium.org/1169002/diff/1/2#newcode305 test/cctest/test-log-stack-tracer.cc:305: sample.stack[1]); On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done. http://codereview.chromium.org/1169002/diff/1/2#newcode316 test/cctest/test-log-stack-tracer.cc:316: CHECK(!CompileRun( On 2010/03/23 11:53:28, Kasper Lund wrote:
I would create a local handle for the result and do
CHECK(!result.IsEmpty())
separately.
Done. http://codereview.chromium.org/1169002/diff/1/2#newcode331 test/cctest/test-log-stack-tracer.cc:331: sample.stack[0]); On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done. http://codereview.chromium.org/1169002/diff/1/2#newcode333 test/cctest/test-log-stack-tracer.cc:333: sample.stack[1]); On 2010/03/23 11:53:28, Kasper Lund wrote:
Indentation.
Done. http://codereview.chromium.org/1169002 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
