Thanks a lot for review, Mads.
http://codereview.chromium.org/1076010/diff/1/2 File src/builtins.cc (right): http://codereview.chromium.org/1076010/diff/1/2#newcode448 src/builtins.cc:448: // In large object space object's start must coincide with chunk On 2010/03/23 12:36:50, Mads Ager wrote:
object's -> the object's
Done. http://codereview.chromium.org/1076010/diff/1/2#newcode450 src/builtins.cc:450: // In old space I'd rather not play rset tricks like On 2010/03/23 12:36:50, Mads Ager wrote:
How about: In old space we do not use this trick to avoid dealing with remembered sets.
Done. http://codereview.chromium.org/1076010/diff/1/2#newcode473 src/builtins.cc:473: ASSERT(elms->address() + kPointerSize On 2010/03/23 12:36:50, Mads Ager wrote:
Doesn't this fit on one line?
Done. http://codereview.chromium.org/1076010 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
