On 2010/03/23 13:35:11, Alexandre wrote:
Hi,
I corrected test-mips.cc and changed SetupAlignedCall code.
I think your problem running tools/test.py --simulator=mips is that your
src/flag-definitions.h is not good for MIPS.
You need these diffs to have it work:
Index: src/flag-definitions.h
===================================================================
--- src/flag-definitions.h (revision 4138)
+++ src/flag-definitions.h (working copy)
@@ -122,7 +122,7 @@
// bootstrapper.cc
DEFINE_string(expose_natives_as, NULL, "expose natives in global object")
DEFINE_string(expose_debug_as, NULL, "expose debug in global object")
-DEFINE_string(natives_file, NULL, "alternative natives file")
+DEFINE_string(natives_file, "", "alternative natives file")
DEFINE_bool(expose_gc, false, "expose gc extension")
DEFINE_int(stack_trace_limit, 10, "number of stack frames to capture")
@@ -145,7 +145,7 @@
DEFINE_bool(strict, false, "strict error checking")
DEFINE_int(min_preparse_length, 1024,
"minimum length for automatic enable preparsing")
-DEFINE_bool(full_compiler, true, "enable dedicated backend for run-once
code")
+DEFINE_bool(full_compiler, false, "enable dedicated backend for run-once
code")
DEFINE_bool(fast_compiler, false, "enable speculative optimizing
backend")
DEFINE_bool(always_full_compiler, false,
"try to use the dedicated run-once backend for all code")
Regards,
Alexandre
http://codereview.chromium.org/1018001/diff/45001/46014
File test/cctest/test-mips.cc (right):
http://codereview.chromium.org/1018001/diff/45001/46014#newcode38
test/cctest/test-mips.cc:38: TEST(MIPS_function_calls) {
On 2010/03/23 11:15:40, Søren Gjesse wrote:
> Please rename the test to MIPSFunctionCall.
Done.
http://codereview.chromium.org/1018001/diff/45001/46014#newcode42
test/cctest/test-mips.cc:42: const char* c_source = "function foo() {
return
0x1234; }; foo();";
On 2010/03/23 11:15:40, Søren Gjesse wrote:
> Can't you do without ::v8:: here?
I can. Removed it.
Landed through http://codereview.chromium.org/1140004. Closing this issue.
http://codereview.chromium.org/1018001
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply
to this email with the words "REMOVE ME" as the subject.
