http://codereview.chromium.org/1117011/diff/1009/6002 File src/ia32/codegen-ia32.cc (right):
http://codereview.chromium.org/1117011/diff/1009/6002#newcode2736 src/ia32/codegen-ia32.cc:2736: if (nan_info == kCantBothBeNaN && cc == equal) { On 2010/03/23 18:09:24, Erik Corry wrote:
This seems wrong. If one side is a constant fp number then they can't
both be
NaN, but you still have to check whether the other side is a number or
a JS
object with an arbitrary ToNumber method with side effects. If we
insisted on
strict equality it might be OK.
This will only provide true when the objects are the same, but not false if they are different. If they are not the same objects all the rest of the compare code will perform all the rest of the checks. http://codereview.chromium.org/1117011 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
