LGTM with comments addressed.
http://codereview.chromium.org/1520001/diff/1/2 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1520001/diff/1/2#newcode1198 src/ia32/codegen-ia32.cc:1198: } else if (operands_type.IsString()) { Actually the result of ADD is a string if either on both operands is a string. So I think you could write here: if (left.is_string() || right.is_string()) { return TypeInfo::String; } http://codereview.chromium.org/1520001/diff/1/2#newcode7137 src/ia32/codegen-ia32.cc:7137: old_value.set_type_info(TypeInfo::Number()); I'm not sure we can do that here. It is safe now because we don't make use of the fact the old_value is a number. But we have not called ToNumber on the input yet. I think you move this to after the deferred code exit where we are sure that the returned value (old_value is the case of postfix) is a number. Another improvement would be to avoid calling ToNumber if we know that the input is a number but not a smi before. http://codereview.chromium.org/1520001 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
