LGTM with comments addressed.
http://codereview.chromium.org/1530003/diff/1/6 File src/data-flow.cc (right): http://codereview.chromium.org/1530003/diff/1/6#newcode668 src/data-flow.cc:668: ProcessExpression(expr->key()); That should be ProcessExpression(expr->obj()); http://codereview.chromium.org/1530003/diff/1/8 File src/flow-graph.cc (right): http://codereview.chromium.org/1530003/diff/1/8#newcode262 src/flow-graph.cc:262: current_->AddInstruction(expr); UNREACHABLE() here? Since literals are always trivial, do you ever visit them? http://codereview.chromium.org/1530003/diff/1/9 File src/flow-graph.h (right): http://codereview.chromium.org/1530003/diff/1/9#newcode53 src/flow-graph.h:53: BasicBlock(BasicBlock* predecessor) explicit for 1-argument constructors? http://codereview.chromium.org/1530003/diff/1/9#newcode113 src/flow-graph.h:113: ZoneList<AstNode*> instructions_; We probably need an accessor for instructions_. But it's ok to add it on first use in a separate change. http://codereview.chromium.org/1530003 -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe from this group, send email to v8-dev+unsubscribegooglegroups.com or reply to this email with the words "REMOVE ME" as the subject.
