Christian is less involved with v8 these days.
It's mostly lgtm (modulo minor stylistic nits). I hope it won't affect
performance (it shouldn't)---writing strings out is on some hot paths---but
we
need to land this patch to check it.
http://codereview.chromium.org/1539013/diff/1/3
File src/api.cc (right):
http://codereview.chromium.org/1539013/diff/1/3#newcode2642
src/api.cc:2642: int String::WriteUtf8(char* buffer, int capacity, int
*ncharsRef) const {
nit: v8 style is to use nchars_ref and * immediately after the type.
http://codereview.chromium.org/1539013/diff/1/3#newcode2682
src/api.cc:2682: if (ncharsRef) *ncharsRef = nchars;
nit: v8 style is explicit check against NULL (not 0):
if (nchars_ref != NULL) *nchars_ref = nchars;
http://codereview.chromium.org/1539013/diff/1/4
File test/cctest/test-strings.cc (right):
http://codereview.chromium.org/1539013/diff/1/4#newcode326
test/cctest/test-strings.cc:326: const int charLengths[12] = {0, 0, 1,
2, 2, 2, 3, 4, 4, 4, 5, 5};
ditto for charLengths (char_lengths) and charsWritten (chars_written)
http://codereview.chromium.org/1539013
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
