As we discussed Anton, I would like the rename or the flag. Exposing flattening directly as an API seems too specific to the current string concatenation implementation.
Thanks, -- Mads On Fri, Apr 9, 2010 at 11:55 AM, Anton Muhin <[email protected]> wrote: > If you could come up by some heuristics, it would be really great. > The simplest thing is to check if the string has been written more > than once (maybe we could steal a bit), but ideally it should trigger > flattening given too many accesses to individual characters (from API, > from JS?). > > Could we keep this function for now (maybe renaming it into something > like PrepareForSequentialAccess---I know name is horrible) until > someone comes up by a good way to solve that? > > Another approach might be to pass a hint flag into Write function. > Something like: WriteUtf(EXPECT_SUBSEQUENT_WRITES). > > What do you think? > > yours, > anton. > > On Fri, Apr 9, 2010 at 12:09 PM, <[email protected]> wrote: >> I'm don't really like exposing flattening in the API. It is an >> implementation >> detail that we are using cons strings for string concatenation. Which >> operation >> is the problem here. It seems that we need better heuristics internally in >> V8 to >> handle this instead of spilling implementation details out through the API? >> >> http://codereview.chromium.org/1512028/show >> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
