Reviewers: Mads Ager, Description: Fix minor error in optimized comparison to single-character string.
Please review this at http://codereview.chromium.org/1610025/show SVN Base: http://v8.googlecode.com/svn/branches/2.1/ Affected files: M src/ia32/codegen-ia32.cc M src/version.cc Index: src/ia32/codegen-ia32.cc =================================================================== --- src/ia32/codegen-ia32.cc (revision 4398) +++ src/ia32/codegen-ia32.cc (working copy) @@ -2428,7 +2428,8 @@ left_side_constant_null = left_side.handle()->IsNull(); left_side_constant_1_char_string = (left_side.handle()->IsString() && - (String::cast(*left_side.handle())->length() == 1)); + String::cast(*left_side.handle())->length() == 1 && + String::cast(*left_side.handle())->IsAsciiRepresentation()); } bool right_side_constant_smi = false; bool right_side_constant_null = false; @@ -2438,7 +2439,8 @@ right_side_constant_null = right_side.handle()->IsNull(); right_side_constant_1_char_string = (right_side.handle()->IsString() && - (String::cast(*right_side.handle())->length() == 1)); + String::cast(*right_side.handle())->length() == 1 && + String::cast(*right_side.handle())->IsAsciiRepresentation()); } if (left_side_constant_smi || right_side_constant_smi) { Index: src/version.cc =================================================================== --- src/version.cc (revision 4398) +++ src/version.cc (working copy) @@ -35,7 +35,7 @@ #define MAJOR_VERSION 2 #define MINOR_VERSION 1 #define BUILD_NUMBER 10 -#define PATCH_LEVEL 4 +#define PATCH_LEVEL 5 #define CANDIDATE_VERSION false // Define SONAME to have the SCons build the put a specific SONAME into the -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev To unsubscribe, reply using "remove me" as the subject.
