Revision: 4405
Author: [email protected]
Date: Wed Apr 14 01:11:23 2010
Log: Fix minor error in optimized comparison to single-character string.
Review URL: http://codereview.chromium.org/1610025
http://code.google.com/p/v8/source/detail?r=4405
Modified:
/branches/2.1/src/ia32/codegen-ia32.cc
/branches/2.1/src/version.cc
=======================================
--- /branches/2.1/src/ia32/codegen-ia32.cc Fri Mar 26 02:27:16 2010
+++ /branches/2.1/src/ia32/codegen-ia32.cc Wed Apr 14 01:11:23 2010
@@ -2428,7 +2428,8 @@
left_side_constant_null = left_side.handle()->IsNull();
left_side_constant_1_char_string =
(left_side.handle()->IsString() &&
- (String::cast(*left_side.handle())->length() == 1));
+ String::cast(*left_side.handle())->length() == 1 &&
+ String::cast(*left_side.handle())->IsAsciiRepresentation());
}
bool right_side_constant_smi = false;
bool right_side_constant_null = false;
@@ -2438,7 +2439,8 @@
right_side_constant_null = right_side.handle()->IsNull();
right_side_constant_1_char_string =
(right_side.handle()->IsString() &&
- (String::cast(*right_side.handle())->length() == 1));
+ String::cast(*right_side.handle())->length() == 1 &&
+ String::cast(*right_side.handle())->IsAsciiRepresentation());
}
if (left_side_constant_smi || right_side_constant_smi) {
=======================================
--- /branches/2.1/src/version.cc Thu Apr 1 02:17:24 2010
+++ /branches/2.1/src/version.cc Wed Apr 14 01:11:23 2010
@@ -35,7 +35,7 @@
#define MAJOR_VERSION 2
#define MINOR_VERSION 1
#define BUILD_NUMBER 10
-#define PATCH_LEVEL 4
+#define PATCH_LEVEL 5
#define CANDIDATE_VERSION false
// Define SONAME to have the SCons build the put a specific SONAME into the
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
To unsubscribe, reply using "remove me" as the subject.
