drive by question

http://codereview.chromium.org/1735007/diff/15001/16001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/1735007/diff/15001/16001#newcode5389
src/arm/codegen-arm.cc:5389: __ tst(r0, Operand(kSmiTagMask));
r0 is an object, no?  Should it be r1 and check that key is smi?

And sorry for being pushy but there is BranchOnSmi

http://codereview.chromium.org/1735007/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to