LGTM
http://codereview.chromium.org/1699005/diff/1/2 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/1699005/diff/1/2#newcode1492 src/ia32/stub-cache-ia32.cc:1492: return result; Add an assert before the return to ensure that the result is a Code*. http://codereview.chromium.org/1699005/diff/1/3 File test/mjsunit/array-pop.js (right): http://codereview.chromium.org/1699005/diff/1/3#newcode63 test/mjsunit/array-pop.js:63: // Play with prototype chains. Change description to say that it's using a non-JSArray as receiver for the pop, and that it's a test for custom generators. http://codereview.chromium.org/1699005/diff/1/4 File test/mjsunit/array-push.js (right): http://codereview.chromium.org/1699005/diff/1/4#newcode107 test/mjsunit/array-push.js:107: // Play with prototype chains. Same comment as for pop. http://codereview.chromium.org/1699005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
