LGTM
http://codereview.chromium.org/1719021/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/1719021/diff/1/2#newcode5305 src/arm/codegen-arm.cc:5305: __ DecrementCounter(&Counters::keyed_store_inline, 1, r1, r2); Let's use VirtualFrame::scratch0() and scratch1() for these. http://codereview.chromium.org/1719021/diff/1/2#newcode5310 src/arm/codegen-arm.cc:5310: // Call keyed load IC. It has all arguments on the stack. Comment out of date. Is the value still in r0 here? http://codereview.chromium.org/1719021/diff/1/2#newcode5463 src/arm/codegen-arm.cc:5463: // Generate inlined version of the keyed store if the code is in a loop We should assert that registers are spilled. http://codereview.chromium.org/1719021/diff/1/2#newcode5489 src/arm/codegen-arm.cc:5489: // Load the receiver from the stack. Perhaps we could hoist this load so it can execute in parallel with the tst and branch above. http://codereview.chromium.org/1719021/diff/1/2#newcode5659 src/arm/codegen-arm.cc:5659: frame->EmitPop(r0); // Value. Use FlushAllButCopyTOSToR0. http://codereview.chromium.org/1719021/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
