Deleting the test seems like a risky way to disable it. Why not change cctest.status?
If you do delete it, you should file a V8 issue to investigate and reenable the test. On Wed, Apr 28, 2010 at 12:10 PM, <[email protected]> wrote: > Revision: 4528 > Author: [email protected] > Date: Wed Apr 28 03:09:20 2010 > Log: Temporarily disable DebugContextIsPreservedBetweenAccesses which fails > when snapshot=on > > TBR=sgjesse > Review URL: http://codereview.chromium.org/1723018 > http://code.google.com/p/v8/source/detail?r=4528 > > Modified: > /branches/bleeding_edge/test/cctest/test-debug.cc > > ======================================= > --- /branches/bleeding_edge/test/cctest/test-debug.cc Wed Apr 28 02:18:53 > 2010 > +++ /branches/bleeding_edge/test/cctest/test-debug.cc Wed Apr 28 03:09:20 > 2010 > @@ -6147,13 +6147,3 @@ > } > > > -TEST(DebugContextIsPreservedBetweenAccesses) { > - v8::HandleScope scope; > - v8::Local<v8::Context> context1 = v8::Debug::GetDebugContext(); > - v8::Local<v8::Context> context2 = v8::Debug::GetDebugContext(); > - CHECK_EQ(*context1, *context2); > - // Make sure debugger is unloaded before running other tests. > - v8::internal::ForceUnloadDebugger(); > - CheckDebuggerUnloaded(); > -} > - > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
