LGTM
http://codereview.chromium.org/1709008/diff/3001/4003 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1709008/diff/3001/4003#newcode6680 src/ia32/codegen-ia32.cc:6680: if (FLAG_debug_code) __ AbortIfNotSmi(index2.reg()); You should still test that they are valid. I.e., that they are smis and below elements length. (You are relying on the calling code to be safe, which is not stable under rewriting). http://codereview.chromium.org/1709008/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
