LGTM
http://codereview.chromium.org/1695007/diff/22001/23004 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/1695007/diff/22001/23004#newcode4446 src/x64/codegen-x64.cc:4446: return FieldOperand(array, index, times_pointer_size, How about a comment here that explains the expected content of the registers (array: FixedArray*, index: int32). Maybe even change additional_offset to be number of elements (instead of pre-multiplying by kPointerSize at the call site)? http://codereview.chromium.org/1695007/diff/22001/23004#newcode4608 src/x64/codegen-x64.cc:4608: __ cmpq(key.reg(), ArrayElement(cache.reg(), tmp.reg())); I don't think this makes much difference from using SmiIndex, except for getting to use ArrayElement. I would prefer to keep SmiIndex, since it would stay optimal even if the smi representation changes. http://codereview.chromium.org/1695007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
