http://codereview.chromium.org/1985004/diff/2002/9002 File src/top.cc (right):
http://codereview.chromium.org/1985004/diff/2002/9002#newcode396 src/top.cc:396: int line_number = GetScriptLineNumber(Handle<Script>(script), position); How about adding a function GetScriptLocalLineNumber which does not take the offset into account? http://codereview.chromium.org/1985004/diff/2002/9002#newcode422 src/top.cc:422: if (fun_name->ToBoolean()->IsFalse()) { Any reason for changing this? I just looked at the code, and we have at least three ways of checking this if (!fun_name->IsString()) if (fun_name->IsUndefined()) if (fun_name->ToBoolean()->IsFalse()) I think we should be consistent, so I suggest adding a function called something likeGetNameOrInferredName/GetDisplayName/GetFriendlyName to JSFunction and use that in all places where the inferred name is returned if no actual name is found. http://codereview.chromium.org/1985004/diff/2002/9001 File test/cctest/test-api.cc (right): http://codereview.chromium.org/1985004/diff/2002/9001#newcode9691 test/cctest/test-api.cc:9691: v8::ScriptOrigin detailed_origin(origin, line_offset); How about adding a test with a column offset as well? http://codereview.chromium.org/1985004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
