LGTM apart from the behaviour with const.
http://codereview.chromium.org/2027002/diff/5001/6004 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2027002/diff/5001/6004#newcode3705 src/arm/codegen-arm.cc:3705: // JavaScript example: 'with (obj) foo(1, 2, 3)' // foo is in obj Is this the right comment. The code looks more related to 'eval' than 'with'. Perhaps should say "foo may be in obj." http://codereview.chromium.org/2027002/diff/5001/6004#newcode3727 src/arm/codegen-arm.cc:3727: // This rules out argument loads. This rules out argument loads since the eval forces arguments into an arguments array. http://codereview.chromium.org/2027002/diff/5001/6004#newcode3757 src/arm/codegen-arm.cc:3757: done.Bind(); At this point everything is spilled but the function and receiver are in r0 and r1. I think a comment to that effect is in order. http://codereview.chromium.org/2027002/diff/5001/6003 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2027002/diff/5001/6003#newcode2905 src/x64/codegen-x64.cc:2905: done.Branch(not_equal, &function); Should this skip the Push and the LoadGlobalReceiver. http://codereview.chromium.org/2027002/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
