http://codereview.chromium.org/1758013/diff/4001/5003 File src/platform-posix.cc (right):
http://codereview.chromium.org/1758013/diff/4001/5003#newcode111 src/platform-posix.cc:111: time_t tv = static_cast<time_t>(time / msPerSecond); I've reverted my change to this function as I'm not using it anymore. On 2010/05/17 07:29:20, William Hesse wrote:
Eliminating the floor call changes the answer if time is negative.
Are we not
calling this function with negative values? If so, comment.
http://codereview.chromium.org/1758013/diff/4001/5006 File src/runtime.cc (right): http://codereview.chromium.org/1758013/diff/4001/5006#newcode7280 src/runtime.cc:7280: static int EquivalentTime(double t) { According to ECMA spec, Georgian calendar is assumed to be effective for all dates. I'm not aware of any special rules for years divisible by 1000. I thought only the years 100 and 400 are special cases and luckily the number of days in 400 years is divisible by 7. On 2010/05/17 07:29:20, William Hesse wrote:
This doesn't work. There are also special rules for years divisible
by 1000,
and there is the calendar shift to the Gregorian calendar. Also,
Windows now
can return different DST values for different equivalent years in the
range 1970
- present, and for compatibility, we report those different DST
values. Only
for years outside the range 1970-2037(?) do we use the equivalent
year. http://codereview.chromium.org/1758013/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
