And I would love to see tons of tests :)

http://codereview.chromium.org/2280007/diff/1/20
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/2280007/diff/1/20#newcode293
src/arm/ic-arm.cc:293: CallModeFlag call_mode) {
why call_mode is not used here and in methods below.

http://codereview.chromium.org/2280007/diff/1/7
File src/ia32/full-codegen-ia32.cc (right):

http://codereview.chromium.org/2280007/diff/1/7#newcode1851
src/ia32/full-codegen-ia32.cc:1851: if (prop->is_synthetic()) {
that is weird: you've checked prop->is_synthetic above, don't you?

http://codereview.chromium.org/2280007/show

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev

Reply via email to