Anton, please take a look at the two new tests in test-api.cc.
http://codereview.chromium.org/2280007/diff/72002/86010 File src/ia32/ic-ia32.cc (right): http://codereview.chromium.org/2280007/diff/72002/86010#newcode1321 src/ia32/ic-ia32.cc:1321: // Check that the receiver is a valid JS object. On 2010/06/04 09:22:17, Mads Ager wrote:
Use CmpObjectType for this?
Done. http://codereview.chromium.org/2280007/diff/72002/86021 File src/log.h (right): http://codereview.chromium.org/2280007/diff/72002/86021#newcode111 src/log.h:111: "KeyedCallDebugPrepareStepIn", \ On 2010/06/04 09:22:17, Mads Ager wrote:
Strange indentation. I understand why you did it this way but I would
prefer:
V(KEYED_..., "Keyed...", "kcdbsi")
Done. http://codereview.chromium.org/2280007/diff/72002/86030 File test/mjsunit/keyed-call-ic.js (right): http://codereview.chromium.org/2280007/diff/72002/86030#newcode1 test/mjsunit/keyed-call-ic.js:1: // Copyright 2008 the V8 project authors. All rights reserved. On 2010/06/04 09:22:17, Mads Ager wrote:
2010
Done. http://codereview.chromium.org/2280007/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
