Almost there.
http://codereview.chromium.org/2450005/diff/17001/18002 File src/isolate.h (right): http://codereview.chromium.org/2450005/diff/17001/18002#newcode88 src/isolate.h:88: nit: Remove extra blank line. http://codereview.chromium.org/2450005/diff/17001/18002#newcode99 src/isolate.h:99: static int number_of_isolates_; Add TODO(isolates) mentioning that access to this global counter has to be serialized. http://codereview.chromium.org/2450005/diff/17001/18003 File src/serialize.cc (right): http://codereview.chromium.org/2450005/diff/17001/18003#newcode1015 src/serialize.cc:1015: for (int index = Isolate::Current() OK, looking at functions like this I don't think our initial idea to first do simple text replacements and then optimize them all later in one pass is going to work. Because of reformatting it already involves some manual work, so why not do it (almost) right the first time? Another reason is that when we switch to relatively expensive TLS read we'll have better understanding of performance. So please convert functions in this file that touch the current isolate in every line to do it only once. It'll help readability and performance. http://codereview.chromium.org/2450005/diff/17001/18004 File src/serialize.h (right): http://codereview.chromium.org/2450005/diff/17001/18004#newcode327 src/serialize.h:327: ExternalReferenceDecoder* decoder_; I don't think shortening this field's name is justified. http://codereview.chromium.org/2450005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
