Revision: 4821
Author: [email protected]
Date: Tue Jun  8 05:20:24 2010
Log: Add parenthesis around '&&' within '||'

Warning by some gcc versions. Adding the parenthesis made the condition correct.

[email protected]
Review URL: http://codereview.chromium.org/2725003
http://code.google.com/p/v8/source/detail?r=4821

Modified:
 /branches/bleeding_edge/src/arm/assembler-arm-inl.h
 /branches/bleeding_edge/src/ia32/assembler-ia32-inl.h
 /branches/bleeding_edge/src/x64/assembler-x64-inl.h

=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm-inl.h Tue Jun 8 05:04:49 2010 +++ /branches/bleeding_edge/src/arm/assembler-arm-inl.h Tue Jun 8 05:20:24 2010
@@ -184,10 +184,10 @@
     visitor->VisitExternalReference(target_reference_address());
 #ifdef ENABLE_DEBUGGER_SUPPORT
   } else if (Debug::has_break_points() &&
-             (RelocInfo::IsJSReturn(mode) &&
+             ((RelocInfo::IsJSReturn(mode) &&
               IsPatchedReturnSequence()) ||
              (RelocInfo::IsDebugBreakSlot(mode) &&
-              IsPatchedDebugBreakSlotSequence())) {
+              IsPatchedDebugBreakSlotSequence()))) {
     visitor->VisitDebugTarget(this);
 #endif
   } else if (mode == RelocInfo::RUNTIME_ENTRY) {
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32-inl.h Tue Jun 8 05:04:49 2010 +++ /branches/bleeding_edge/src/ia32/assembler-ia32-inl.h Tue Jun 8 05:20:24 2010
@@ -174,10 +174,10 @@
     visitor->VisitExternalReference(target_reference_address());
 #ifdef ENABLE_DEBUGGER_SUPPORT
   } else if (Debug::has_break_points() &&
-             (RelocInfo::IsJSReturn(mode) &&
+             ((RelocInfo::IsJSReturn(mode) &&
               IsPatchedReturnSequence()) ||
              (RelocInfo::IsDebugBreakSlot(mode) &&
-              IsPatchedDebugBreakSlotSequence())) {
+              IsPatchedDebugBreakSlotSequence()))) {
     visitor->VisitDebugTarget(this);
 #endif
   } else if (mode == RelocInfo::RUNTIME_ENTRY) {
=======================================
--- /branches/bleeding_edge/src/x64/assembler-x64-inl.h Tue Jun 8 05:04:49 2010 +++ /branches/bleeding_edge/src/x64/assembler-x64-inl.h Tue Jun 8 05:20:24 2010
@@ -350,10 +350,10 @@
     visitor->VisitExternalReference(target_reference_address());
 #ifdef ENABLE_DEBUGGER_SUPPORT
   } else if (Debug::has_break_points() &&
-             (RelocInfo::IsJSReturn(mode) &&
+             ((RelocInfo::IsJSReturn(mode) &&
               IsPatchedReturnSequence()) ||
              (RelocInfo::IsDebugBreakSlot(mode) &&
-              IsPatchedDebugBreakSlotSequence())) {
+              IsPatchedDebugBreakSlotSequence()))) {
     visitor->VisitDebugTarget(this);
 #endif
   } else if (mode == RelocInfo::RUNTIME_ENTRY) {

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to