LGTM
http://codereview.chromium.org/2832001/diff/4001/5002 File src/runtime.cc (right): http://codereview.chromium.org/2832001/diff/4001/5002#newcode3873 src/runtime.cc:3873: // Check if this is an element. Could we move this check earlier? We should only search for the property as a named property if it is not an array index. http://codereview.chromium.org/2832001/diff/4001/5002#newcode3880 src/runtime.cc:3880: if ((unchecked & (DONT_DELETE | DONT_ENUM | READ_ONLY)) && Explictly check not equal to 0? http://codereview.chromium.org/2832001/diff/4001/5004 File test/mjsunit/object-define-property.js (right): http://codereview.chromium.org/2832001/diff/4001/5004#newcode726 test/mjsunit/object-define-property.js:726: var descElement = {value: 'foobar'}; Please add a bit more spacing for these literals: { value: 'foobar' } http://codereview.chromium.org/2832001/diff/4001/5004#newcode783 test/mjsunit/object-define-property.js:783: // Define non existing property - all attributes should default to false Period at end of comment. http://codereview.chromium.org/2832001/diff/4001/5004#newcode804 test/mjsunit/object-define-property.js:804: var descElement = {value: 'foobar'}; A bit of spacing. http://codereview.chromium.org/2832001/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
