LGTM
http://codereview.chromium.org/2872005/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/2872005/diff/1/4#newcode4843 src/x64/codegen-x64.cc:4843: // r9 holds the index as int32. comments on line 4837 and 4843 say the same thing with different words. unify? http://codereview.chromium.org/2872005/diff/1/4#newcode8704 src/x64/codegen-x64.cc:8704: remove empty line? http://codereview.chromium.org/2872005/diff/1/6 File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/2872005/diff/1/6#newcode509 src/x64/macro-assembler-x64.cc:509: movl(Operand(dst, kSmiShift / kBitsPerByte), src); ASSERT that (kSmiShift % kBitsPerByte) == 0? http://codereview.chromium.org/2872005/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
