LGTM
http://codereview.chromium.org/2846012/diff/1/5 File src/profile-generator.cc (right): http://codereview.chromium.org/2846012/diff/1/5#newcode856 src/profile-generator.cc:856: new HeapGraphEdge(HeapGraphEdge::CONTEXT_VARIABLE, name, this, entry)); How about moving the "new HeapGraphEdge(...)" into AddEdge and pass the four arguments to it instead? http://codereview.chromium.org/2846012/diff/1/7 File test/cctest/test-heap-profiler.cc (right): http://codereview.chromium.org/2846012/diff/1/7#newcode589 test/cctest/test-heap-profiler.cc:589: "function non_compiled(x) { return x - 1; }\n" Maybe non_compiled -> compiled_lazy. http://codereview.chromium.org/2846012/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
