Cool! Just a couple of tiny formatting nits:
http://codereview.chromium.org/2804009/diff/12001/13005 File src/compilation-cache.cc (right): http://codereview.chromium.org/2804009/diff/12001/13005#newcode50 src/compilation-cache.cc:50: :script_(kScriptGenerations), spacing, should be: foo::foo() : bar_(baz), goo_(gaz), etc http://codereview.chromium.org/2804009/diff/12001/13005#newcode57 src/compilation-cache.cc:57: for (int i = 0; i < sizeof(subcaches) / sizeof(subcaches[0]); ++i) { The rest of this file uses loops with kSubCacheCount as an upper limit, makes sense to be consistent. http://codereview.chromium.org/2804009/diff/12001/13005#newcode331 src/compilation-cache.cc:331: Lookup(source, name, line_offset, column_offset); looks like an extra line break here http://codereview.chromium.org/2804009/diff/12001/13003 File src/compilation-cache.h (right): http://codereview.chromium.org/2804009/diff/12001/13003#newcode235 src/compilation-cache.h:235: return FLAG_compilation_cache && enabled_; If it fits 80 characters, this kind of inline is usually on a single line. http://codereview.chromium.org/2804009/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
