Reviewers: Vitaly, Dmitry Titov,
Message:
Thanks
Luke
http://codereview.chromium.org/2841023/diff/29001/30004
File src/api.h (left):
http://codereview.chromium.org/2841023/diff/29001/30004#oldcode168
src/api.h:168: static RegisteredExtension* first_auto_extension_;
This is not used.
http://codereview.chromium.org/2841023/diff/29001/30011
File src/global-handles.cc (right):
http://codereview.chromium.org/2841023/diff/29001/30011#newcode39
src/global-handles.cc:39: void Initialize(GlobalHandles* global_handles,
Object* object) {
global_handles_ != NULL if state_ != DESTROYED
Description:
[Isolates] Remove statics from malloc + dependencies.
- Removed statics from Debugger.
- Removed statics from GlobalHandles.
- Removed statics from PreallocatedStorage and NativeAllocationChecker.
- Removed statics from ThreadState and ThreadManager.
- Removed various statics from api.cc:
* exception_behavior
* write_input_buffer
* next_serial_number
* StringTracker::use_count_; StringTracker::last_top_
* internal buffer from GetVersion
* message_handler
- Changed cctest.cc to fix potential static initialization ordering
problems.
- Fixed a null dereference in log.cc wrt profiler_. This bug is also in
bleeding_edge.
Please review this at http://codereview.chromium.org/2841023/show
SVN Base: http://v8.googlecode.com/svn/branches/experimental/isolates/
Affected files:
M src/allocation.h
M src/allocation.cc
M src/api.h
M src/api.cc
M src/bootstrapper.cc
M src/compiler.cc
M src/debug.h
M src/debug.cc
M src/execution.cc
M src/full-codegen.cc
M src/global-handles.h
M src/global-handles.cc
M src/handles.cc
M src/heap-profiler.cc
M src/heap.h
M src/heap.cc
M src/isolate.h
M src/isolate.cc
M src/liveedit.cc
M src/log.cc
M src/mark-compact.cc
M src/platform-linux.cc
M src/profile-generator.cc
M src/runtime.cc
M src/scanner.h
M src/scanner.cc
M src/serialize.cc
M src/top.cc
M src/v8threads.h
M src/v8threads.cc
M test/cctest/cctest.cc
M test/cctest/test-debug.cc
M test/cctest/test-heap.cc
M test/cctest/test-log.cc
M test/cctest/test-mark-compact.cc
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
