LGTM
http://codereview.chromium.org/2862032/diff/1/5 File src/regexp-macro-assembler.cc (right): http://codereview.chromium.org/2862032/diff/1/5#newcode188 src/regexp-macro-assembler.cc:188: // TODO(isolates): Verify that this is used as a constant. It's only used in load operations. Please add "const" and consider the todo done. http://codereview.chromium.org/2862032/diff/1/9 File src/spaces.h (right): http://codereview.chromium.org/2862032/diff/1/9#newcode2216 src/spaces.h:2216: // must be small, since an iteration is used for lookup nit: "Must" and full stop at the end. http://codereview.chromium.org/2862032/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
