http://codereview.chromium.org/2962007/diff/1/2 File include/v8-debug.h (right):
http://codereview.chromium.org/2962007/diff/1/2#newcode258 include/v8-debug.h:258: static void DebugBreak(void* data = NULL); It becomes non-deterministic, last caller of the method will override previous value. The value may leak. Also with this implementation we won't be able to distinguish between execution interrupts that were meant to be script pauses and others that were scheduled to perform an action with v8 on the thread where JS is executing. I think we need some sort of queue to serve what we need in Chrome of this method. http://codereview.chromium.org/2962007/diff/1/6 File src/execution.cc (right): http://codereview.chromium.org/2962007/diff/1/6#newcode303 src/execution.cc:303: void* StackGuard::GetDebugBreakData() { consider renaming it to TakeDebugBreakData as it clears thread_local_.debug_break_data_ http://codereview.chromium.org/2962007/diff/1/7 File src/execution.h (right): http://codereview.chromium.org/2962007/diff/1/7#newcode217 src/execution.h:217: if (should_postpone_interrupts(lock)) return; is this really needed here? http://codereview.chromium.org/2962007/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
