LGTM with these comments addressed.
http://codereview.chromium.org/3046010/diff/10001/11003 File src/v8natives.js (right): http://codereview.chromium.org/3046010/diff/10001/11003#newcode1126 src/v8natives.js:1126: args.unshift.apply(args, boundArgs); Could we allocate a bigger array up front and fill it with boundArgs and args instead of using unshift here? http://codereview.chromium.org/3046010/diff/10001/11003#newcode1134 src/v8natives.js:1134: } else { We should be able to get rid of the else here. There is little difference between if and else branch. http://codereview.chromium.org/3046010/diff/10001/11003#newcode1150 src/v8natives.js:1150: // try to redefine these as defined by the spec. Could you add to the comment what the spec says? http://codereview.chromium.org/3046010/diff/10001/11003#newcode1153 src/v8natives.js:1153: %FunctionSetLength(result, $Math.max(0, this.length - (n-1))); Math.max can be overwritten. Use simple conditional instead. http://codereview.chromium.org/3046010/diff/10001/11004 File test/mjsunit/function-bind.js (right): http://codereview.chromium.org/3046010/diff/10001/11004#newcode158 test/mjsunit/function-bind.js:158: assertFalse(obj2 instanceof f); Add tests for the lengths of bound functions? http://codereview.chromium.org/3046010/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
