http://codereview.chromium.org/3031005/diff/52001/53001 File src/accessors.cc (right):
http://codereview.chromium.org/3031005/diff/52001/53001#newcode44 src/accessors.cc:44: if (obj == heap->null_value()) return NULL; On 2010/08/02 12:49:47, Vitaly wrote:
Here and in lots of other places you're still using comparison to heap->null_value(). Even if there are no other heap usages around. Why
can't
these comparisons be replaced with obj->IsNull()?
It's likely cheaper to go through this sort of comparison in a loop as it would involve a smaller net number of indirections. http://codereview.chromium.org/3031005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
