http://codereview.chromium.org/3030048/diff/33003/19008 File src/spaces.h (right):
http://codereview.chromium.org/3030048/diff/33003/19008#newcode270 src/spaces.h:270: }; There is a subtle (implicit) dependency here: kAllocationWatermarkOffsetShift depends on number of flags. Refactoring suggestion: change enum values from bitmasks to bit positions [modify GetPageFlag/SetPageFlag to use shift] enum PageFlag { IS_NORMAL_PAGE = 0, WAS_IN_USE_BEFORE_MC, WATERMARK_INVALIDATED, IS_EXECUTABLE, kNumberOfPageFlags }; static const int kAllocationWatermarkOffsetShift = kNumberOfPageFlags; http://codereview.chromium.org/3030048/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
