Thanks a lot for review, Mads. Submitting.
http://codereview.chromium.org/3101001/diff/1/2 File include/v8.h (right): http://codereview.chromium.org/3101001/diff/1/2#newcode1822 include/v8.h:1822: * The result is true if either boolean (true if property exists and false On 2010/08/10 08:47:49, Mads Ager wrote:
The result is true if either boolean ... -> The result is either a boolean ...
Done. http://codereview.chromium.org/3101001/diff/1/2#newcode2066 include/v8.h:2066: IndexedPropertyEnumerator enumerator, On 2010/08/10 08:47:49, Mads Ager wrote:
Long line.
Thanks. The strange this is ./tools/presubmit.py didn't catch that. I'll check what happened. http://codereview.chromium.org/3101001/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/3101001/diff/1/4#newcode5836 src/objects.cc:5836: // Temporary complicated logic, would be removed soon. On 2010/08/10 08:47:49, Mads Ager wrote:
Instead of writing that it will be removed soon, can you write that it
will be
removed when then transition to the new signature for indexed query
callbacks is
complete.
Done. http://codereview.chromium.org/3101001/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev
